Skip to content

[Wrangler/Workflows] Add warning on deploy of workflows belonging to other workers#12513

Merged
pombosilva merged 6 commits intomainfrom
osilva/add-workflow-conflict-warning
Feb 11, 2026
Merged

[Wrangler/Workflows] Add warning on deploy of workflows belonging to other workers#12513
pombosilva merged 6 commits intomainfrom
osilva/add-workflow-conflict-warning

Conversation

@pombosilva
Copy link
Contributor

@pombosilva pombosilva commented Feb 10, 2026 •
edited by devin-ai-integration bot
Loading

Fixes WOR-1157.

Adds a confirmation prompt when wrangler deploy detects that a workflow being deployed already exists and belongs to a different worker. This prevents accidental overwrites of workflows between workers.

  • Checks existing workflows via the /accounts/{accountId}/workflows API before deployment
  • Warns the user and lists which workflows would be reassigned and their current owners
  • Prompts for confirmation in interactive mode

Example Output:

⚠️ The following workflow(s) already exist and belong to different workers:
  - "my-workflow" (currently belongs to "other-worker")

Deploying will reassign these workflows to "my-worker".

Do you want to continue? (Y/n)
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Just adds a wrangler deploy check

A picture of a cute animal (not mandatory, but encouraged)
image

Open with Devin

@pombosilva pombosilva requested a review from a team as a code owner February 10, 2026 12:54
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 9501405

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Feb 10, 2026
@claude
Copy link
Contributor

claude bot commented Feb 10, 2026 •
edited
Loading

Claude finished @pombosilva's task —— View job

Changeset Review

Todo List:

  • Read changeset guidelines
  • Review .changeset/workflow-conflict-warning.md
  • Validate against criteria
  • Check for cute animals

✅ All changesets look good

The changeset file .changeset/workflow-conflict-warning.md passes all validation criteria:

  1. ✅ Version Type: patch is appropriate for this safety/warning feature addition
  2. ✅ Changelog Quality: Clear, meaningful description with good context about the behavior
  3. ✅ Markdown Headers: No h1/h2/h3 headers present
  4. ✅ Analytics: Not applicable (no analytics changes)
  5. ✅ Dependabot: Not applicable
  6. ✅ Experimental features: Not applicable

The changeset properly describes the new confirmation prompt behavior and helpfully explains the non-interactive/--strict flag behavior.

Cuteness Report:

This is Nemo (probably). Vibing in their pink palace with absolutely no sense of personal space. Peak "just keep swimming" energy. The coral looks thrilled. 14/10 would definitely get stung trying to pet.

devin-ai-integration[bot]
devin-ai-integration bot reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 5 additional findings in Devin Review.

Open in Devin Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 10, 2026 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12513

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12513

miniflare

npm i https://pkg.pr.new/miniflare@12513

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12513

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12513

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12513

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12513

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12513

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12513

wrangler

npm i https://pkg.pr.new/wrangler@12513

commit: 9501405

@pombosilva pombosilva requested a review from a team February 10, 2026 14:53
LuisDuarte1
LuisDuarte1 reviewed Feb 10, 2026
View reviewed changes
LuisDuarte1
LuisDuarte1 approved these changes Feb 10, 2026
View reviewed changes
Copy link
Contributor

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the workflows team 🚀

@pombosilva pombosilva force-pushed the osilva/add-workflow-conflict-warning branch from 7daeb99 to 9f34f31 Compare February 10, 2026 17:41
vicb
vicb reviewed Feb 10, 2026
View reviewed changes
vicb
vicb reviewed Feb 10, 2026
View reviewed changes
vicb
vicb reviewed Feb 10, 2026
View reviewed changes
vicb
vicb reviewed Feb 10, 2026
View reviewed changes
vicb
vicb reviewed Feb 10, 2026
View reviewed changes
vicb
vicb reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few inline comments

@pombosilva pombosilva force-pushed the osilva/add-workflow-conflict-warning branch 3 times, most recently from 9f45be4 to d69d350 Compare February 11, 2026 14:45
vicb
vicb reviewed Feb 11, 2026
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

vicb
vicb approved these changes Feb 11, 2026
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Feb 11, 2026
@pombosilva pombosilva force-pushed the osilva/add-workflow-conflict-warning branch from 27a679e to 9501405 Compare February 11, 2026 17:58
@pombosilva pombosilva merged commit 41e18aa into main Feb 11, 2026
35 checks passed
@pombosilva pombosilva deleted the osilva/add-workflow-conflict-warning branch February 11, 2026 19:08
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Feb 11, 2026
@workers-devprod workers-devprod mentioned this pull request Feb 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@vicb vicb vicb approved these changes

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pombosilva @vicb @LuisDuarte1